search

oscar-system / oscar-website

Dev repo for the oscar website
https://www.oscar-system.org
8 stars 32 forks source link

Update contributors on OSCAR website #344

Closed HereAround closed 4 months ago

HereAround commented 4 months ago

This PR aims to update the contributor list on the OSCAR site. Contributions to OSCAR.jl, AbstractAlgebra.jl, Singular.jl, Nemo.jl, Hecke.jl, GAP.jl and Polymake.jl are taken into account.

As suggested by @fingolfin, I have classified the contributors as follows:

Here is a preview (two separate screenshots, there is no "cut" in the middle of the actual website):

Screenshot_20240612_165657 Screenshot_20240612_165714

I must mention that for some people listed on the website, finding their information turned into detective's work, which I hope to have completed correctly. Here are some of the trickiest cases:

Despite spending all afternoon on this task, I could not cover all grounds. Rather, the following contributors are yet to be added. (Lists obtained with git shortlog -s --since=2023-06-12):

Oscar.jl 1 Andrei Comaneci 2 BjSchaefer 1 Jan Philipp Thiele 2 Kamillo Ferry 1 Laura Voggesberger 1 Marcel Salmon 1 Nicolas 3 Tobias Boege

Singular.jl 1 Albin Ahlbäck 2 Alexander Demin 2 Julien Schanz

AbstractAlgebra.jl (All listed on the website)

Nemo.jl 3 Albin Ahlbäck 3 Alexander Demin 1 Yichao Yu 1 nanleij

Hecke.jl 1 Berenike Dieterle 1 Fabian Gundlach 1 Grégory Vanuxem 1 Sreevatsa2 2 Tobias Braun

Polymake.jl (All listed on the website)

GAP.jl (All listed on the website)

I will leave it as such for now. @fingolfin @fieker, what are your thoughts? Are people missing? Is there incomplete/wrong information? Desire for a more restrictive criterion identifying contributors? Etc.

Once (If?) you are happy, we could merge this and bring this up in the Friday meeting to hear more thoughts.

fingolfin commented 4 months ago

First off: don't try to hard, it is OK to just list a name without any affiliation or username, those can be added later on if requested, or just left off.

I think something is wrong with your "Singular.jl" list -- I think it is really for AbstractAlgebra.

To find out who e.g. Julien Schanz is you can do this:

  1. use git log --author=Schanz to find a commit authored by him
  2. copy that commit hash
  3. go to https://github.com/Nemocas/AbstractAlgebra.jl/pulls and paste the sha1 you just copied into the "filters" input field (replacing the existing content is:pr is:open) and press return
  4. now you get a list of all PRs in which this commit originally appeared. from this it is often possible to figure out something about that person, e.g. here that the GitHub user name is @julien-schanz (in this case he doesn't have much in his Bio, but I can tell you this is https://www.uni-saarland.de/lehrstuhl/weber-moritz/team/julien-schanz.html)

But again: I am not expecting you to do that for everyone. And I'd just drop incomplete names like nanleij or Nicolas

Some more hints:

HereAround commented 4 months ago

Thank you @fingolfin for the many ideas. Let me address them in this PR. Will ping you once I made those changes.

fieker commented 4 months ago

Pi's: Simon und Tommy fehlen

On Wed, 12 Jun 2024, 19:51 Martin Bies, @.***> wrote:

@.**** commented on this pull request.

In contributors.md https://github.com/oscar-system/oscar-website/pull/344#discussion_r1636876850 :

 github: alexjbest

All emails are public in at least one way. Say by visiting the linked website and then looking up the email there. Once could (in my case) also go through my github profile, which will again link to my website.

Still, if you feel I should remove emails, then this is of course an easy fix.

For all it matters - I have also added emails for all OSCAR book contributors. So this issue repeats for the OSCAR book website/contributors.

— Reply to this email directly, view it on GitHub https://github.com/oscar-system/oscar-website/pull/344#discussion_r1636876850, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA36CV33P5R3ESTFDDA5MEDZHCDB3AVCNFSM6AAAAABJGS4TRWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMJTG4YDSMZYGI . You are receiving this because you were mentioned.Message ID: @.***>

HereAround commented 4 months ago

Pi's: Simon und Tommy fehlen … On Wed, 12 Jun 2024, 19:51 Martin Bies, @.> wrote: @*.*** commented on this pull request. ------------------------------ In contributors.md <#344 (comment)> : > github: alexjbest - name: Martin Bies affiliation: University of Kaiserslautern-Landau website: https://martinbies.github.io + email: @. All emails are public in at least one way. Say by visiting the linked website and then looking up the email there. Once could (in my case) also go through my github profile, which will again link to my website. Still, if you feel I should remove emails, then this is of course an easy fix. For all it matters - I have also added emails for all OSCAR book contributors. So this issue repeats for the OSCAR book website/contributors. — Reply to this email directly, view it on GitHub <#344 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA36CV33P5R3ESTFDDA5MEDZHCDB3AVCNFSM6AAAAABJGS4TRWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMJTG4YDSMZYGI . You are receiving this because you were mentioned.Message ID: @.***>

Thank you. Modified accordingly.

HereAround commented 4 months ago

All changes done except for:

With that being said, @fingolfin @fieker please consider merging if you are happy with the changes.

HereAround commented 4 months ago

(Oh, and I have gone over the remaining names in the list above and added details on these people.)

HereAround commented 4 months ago

@fieker and @fingolfin , I believe this is ready for the next round of review.