oscarbranson / cbsyst

Python module for calculating carbon and boron solution chemistry.
MIT License
29 stars 17 forks source link

Python 2.7 Compatability #12

Closed oscarbranson closed 5 years ago

oscarbranson commented 7 years ago

This is low priority but would be nice. Current incompatibility stems from repeated use of 'Extended Tuple Unpacking' (using *) in numerous function inputs throughout. Can be solved with a generator wrapper (as described here).

Note: To run tests in python 2.x, you need to remove the python 2 incompatability warning in setup.py

efiring commented 5 years ago

I recommend that you close this as out of date and no longer desirable. Adding py2 compatibility now would be a step backward.

oscarbranson commented 5 years ago

Closing, following recommendation of @efiring