oscarbranson / cbsyst

Python module for calculating carbon and boron solution chemistry.
MIT License
29 stars 17 forks source link

Incorrect calculated variables #2

Closed oscarbranson closed 7 years ago

oscarbranson commented 7 years ago

Current vectorised fsolve calls in carbon_fns produce incorrect values when multiple parameters are passed. Identified from Luecker et al (2000) test data. Unclear why.

Solution:

oscarbranson commented 7 years ago

Solution implemented at carbon_fns level. Only accepts two C parameters at once - not mixtures of unknowns. I don't think this is a problem.