search

oscarbranson / cbsyst

Python module for calculating carbon and boron solution chemistry.
MIT License
29 stars 17 forks source link

Fixed the small mislabelling of T and S in Bunch calling in ABsys #24

Closed douglascoenen closed 3 years ago

douglascoenen commented 3 years ago

Fixing the calling of Bunch key from "T" and "S" as "T_in" and "S_in" to fix error when using the ABsys function.

oscarbranson commented 3 years ago

Thanks @douglascoenen!

oscarbranson commented 3 years ago

A quick note, though @douglascoenen - if you're making changes could you please do so in the dev branch? These can then be included in the next release. Helps me keep things organised!

douglascoenen commented 3 years ago

Hello! I am sorry my bad! I will keep this in mind for next time, thank you for the tip! I am still new to code contributions, so thank you for your patience! :)

oscarbranson commented 3 years ago

No worries at all - thanks for contributing! My fault for not having contribution guidelines!

FYI, I just released a new version of cbsyst (0.3.7) containing lots of small fixes and improvements that I've implemented over the last few years. The most important of these is fixing a bug in the MyAMI model, which will be important if you're using seawater with variable [Ca] or [Mg]. I notice you've forked the repository, so you'll have to sync your fork with my upstream version to get those changes in your local version. Apologies if you know all that already - don't mean to patronise... you just mentioned you were new to code contributions!

douglascoenen commented 3 years ago

No please, it is I who is not yet aware of the best practices! Wonderful! I will play around with the new version. I plan on working on boron isotopes in the Eocene, which had different Mg/Ca, so this will come in very handy! On the contrary, very informative! Thank you for the tip! I will be looking forward new updates! :)