search

oscarbranson / cbsyst

Python module for calculating carbon and boron solution chemistry.
MIT License
29 stars 17 forks source link

Boron fractionation factor (alpha_B) ignored when used as input #29

Closed douglascoenen closed 2 years ago

douglascoenen commented 2 years ago

In the list of input from the Bsys or CBsys functions, the alphaB parametre can be manually typed. However, this parametre is never really used. The ps Bunch object is automatically updated using the alphaB_calc function (dependant on temperature, based on the Hoenisch book) and simply ignores the alphaB parametre (i.e. cbsyst.py, line 692 and 1037). Would it be possible to make a simple statement checking if the alphaB is given, and if not calculate it?

douglascoenen commented 2 years ago

My apologies, this issue appears to have been fixed in the dev branch a while ago https://github.com/St-Andrews-Isotope-Geochemistry/cbsyst/commit/3ebf7aec79f7fd9a2514aae9d04b6db907bd8350 I will have to update myself