search

oscarbranson / cbsyst

Python module for calculating carbon and boron solution chemistry.
MIT License
29 stars 17 forks source link

Fix dependencies #32

Closed ocefpaf closed 1 year ago

ocefpaf commented 2 years ago

The move to setup.cfg dropped the dependencies and the sdist on PyPI is broken at the moment. This should fix it. I also moved the find packages to the setup.cfg. The only reason I did not remove the setup.py is b/c we needed it so GitHub can parse the dependency graph.

ocefpaf commented 1 year ago

Looks like you pulled parts of this into https://github.com/oscarbranson/cbsyst/commit/3ac6ace6febbd43d769bb4a6d0482ecd370d62e4

Do you want to consider the updates to the GitHub Actions and the name in the setup.py? If so I can rebase, if not feel free to close this PR.

oscarbranson commented 1 year ago

thanks @ocefpaf! will be included in next release