[x] Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Running the following command:
npm start -- --fotocasa returns all the flats from all neighborhoods
Les Corts is failing
> phantomjs --ssl-protocol=any --ignore-ssl-errors=true index.js "--fotocasa"
-------------------------------------------------------------------
FOTOCASA
-------------------------------------------------------------------
ReferenceError: Can't find variable: Set
phantomjs://code/index.js:71 in onError
****Status: success****
-------------------------------------------------------------------
CIUTAT VELLA
-------------------------------------------------------------------
Apartamento en Gótico
1.250 €/mes
ahora
https://www.fotocasa.es/vivienda/barcelona-capital/calefaccion-amueblado-barri-gotic-147318633?RowGrid=1&tti=3&opi=300
Piso en Riereta, 3
1.050 €/mes
ahora
https://www.fotocasa.es/vivienda/barcelona-capital/calefaccion-amueblado-riereta-3-147273293?RowGrid=2&tti=3&opi=300
Piso en Nou de Sant Francesc
980 €/mes
hace 8 horas
https://www.fotocasa.es/vivienda/barcelona-capital/patio-amueblado-nou-de-sant-francesc-147590518?RowGrid=3&tti=3&opi=300
Piso en Sant Pere Mitja
1.200 €/mes
hace 17 horas
https://www.fotocasa.es/vivienda/barcelona-capital/aire-acondicionado-calefaccion-terraza-patio-amueblado-television-sant-pere-mitja-146734276?RowGrid=4&tti=3&opi=300
ReferenceError: Can't find variable: Set
phantomjs://code/index.js:71 in onError
****Status: success****
-------------------------------------------------------------------
EIXAMPLE
-------------------------------------------------------------------
Piso en Tamarit
1.100 €/mes
ahora
https://www.fotocasa.es/vivienda/barcelona-capital/aire-acondicionado-calefaccion-ascensor-patio-amueblado-tamarit-146258151?RowGrid=1&tti=3&opi=300
Piso en Arago, 343
1.250 €/mes
ahora
https://www.fotocasa.es/vivienda/barcelona-capital/calefaccion-ascensor-amueblado-arago-343-147560379?RowGrid=2&tti=3&opi=300
Piso en Provença, 198
1.200 €/mes
ahora
https://www.fotocasa.es/vivienda/barcelona-capital/aire-acondicionado-calefaccion-ascensor-amueblado-television-provenca-198-147301510?RowGrid=3&tti=3&opi=300
Piso en Av Gaudí
1.200 €/mes
ahora
https://www.fotocasa.es/vivienda/barcelona-capital/ascensor-amueblado-television-av-gaudi-147564611?RowGrid=4&tti=3&opi=300
Piso en Villarroel
1.050 €/mes
ahora
https://www.fotocasa.es/vivienda/barcelona-capital/ascensor-amueblado-villarroel-147565341?RowGrid=5&tti=3&opi=300
Piso en Valencia, 170
1.200 €/mes
hace 3 horas
https://www.fotocasa.es/vivienda/barcelona-capital/aire-acondicionado-calefaccion-ascensor-amueblado-valencia-170-147484613?RowGrid=6&tti=3&opi=300
Piso en Villarroel
1.050 €/mes
hace 4 horas
https://www.fotocasa.es/vivienda/barcelona-capital/ascensor-amueblado-villarroel-147565341?RowGrid=7&tti=3&opi=300
Piso en Av Gaudí
1.200 €/mes
hace 4 horas
https://www.fotocasa.es/vivienda/barcelona-capital/ascensor-amueblado-television-av-gaudi-147564611?RowGrid=8&tti=3&opi=300
Piso en Tamarit
1.250 €/mes
hace 11 horas
https://www.fotocasa.es/vivienda/barcelona-capital/calefaccion-terraza-amueblado-tamarit-147588175?RowGrid=9&tti=3&opi=300
ReferenceError: Can't find variable: Set
phantomjs://code/index.js:71 in onError
****Status: success****
-------------------------------------------------------------------
GRACIA
-------------------------------------------------------------------
Piso en Travesera de Gracia, 102
1.150 €/mes
ahora
https://www.fotocasa.es/vivienda/barcelona-capital/ascensor-amueblado-travesera-de-gracia-102-147232819?RowGrid=1&tti=3&opi=300
Piso en Vila de Gràcia
1.200 €/mes
ahora
https://www.fotocasa.es/vivienda/barcelona-capital/aire-acondicionado-ascensor-amueblado-vila-de-gracia-147454320?RowGrid=2&tti=3&opi=300
Piso en Vila de Gràcia
1.150 €/mes
ahora
https://www.fotocasa.es/vivienda/barcelona-capital/terraza-ascensor-amueblado-vila-de-gracia-146575090?RowGrid=3&tti=3&opi=300
Piso en Martinez de la Rosa
975 €/mes
ahora
https://www.fotocasa.es/vivienda/barcelona-capital/calefaccion-terraza-amueblado-martinez-de-la-rosa-147479526?RowGrid=4&tti=3&opi=300
Apartamento en Gran de Gracia
1.200 €/mes
hace 11 horas
https://www.fotocasa.es/vivienda/barcelona-capital/aire-acondicionado-calefaccion-ascensor-amueblado-gran-de-gracia-147587443?RowGrid=5&tti=3&opi=300
Piso en Martinez de la Rosa
975 €/mes
hace 13 horas
https://www.fotocasa.es/vivienda/barcelona-capital/calefaccion-terraza-amueblado-martinez-de-la-rosa-147479526?RowGrid=6&tti=3&opi=300
****Status: fail****
Error extracting LES CORTS
phantomjs://code/index.js:100 in scrapPage
npm start -- --fotocasa --ciutat-vella returns all the flats from that neighborhood.
> phantomjs --ssl-protocol=any --ignore-ssl-errors=true index.js "--fotocasa" "--ciutat-vella"
-------------------------------------------------------------------
FOTOCASA
-------------------------------------------------------------------
ReferenceError: Can't find variable: Set
phantomjs://code/index.js:71 in onError
****Status: success****
-------------------------------------------------------------------
CIUTAT VELLA
-------------------------------------------------------------------
Apartamento en Gótico
1.250 €/mes
ahora
https://www.fotocasa.es/vivienda/barcelona-capital/calefaccion-amueblado-barri-gotic-147318633?RowGrid=1&tti=3&opi=300
Piso en Riereta, 3
1.050 €/mes
ahora
https://www.fotocasa.es/vivienda/barcelona-capital/calefaccion-amueblado-riereta-3-147273293?RowGrid=2&tti=3&opi=300
Piso en Nou de Sant Francesc
980 €/mes
hace 8 horas
https://www.fotocasa.es/vivienda/barcelona-capital/patio-amueblado-nou-de-sant-francesc-147590518?RowGrid=3&tti=3&opi=300
Piso en Sant Pere Mitja
1.200 €/mes
hace 17 horas
https://www.fotocasa.es/vivienda/barcelona-capital/aire-acondicionado-calefaccion-terraza-patio-amueblado-television-sant-pere-mitja-146734276?RowGrid=4&tti=3&opi=300
Checklist:
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
Description
To fix the selectors
PhantomJS
is working with to scrape the data from fotocasa links:Fixes #13 Fixes #24
Type of change
How Has This Been Tested?
Running the following command:
npm start -- --fotocasa
returns all the flats from all neighborhoods Les Corts is failingnpm start -- --fotocasa --ciutat-vella
returns all the flats from that neighborhood.Checklist: