search

oscard0m / rent-flat-scraper

Scraper with last published flats in idealista
MIT License
7 stars 2 forks source link

precommit hooks #32

Open juanchaur opened 6 years ago

juanchaur commented 6 years ago

Is your feature request related to a problem? Please describe. Follow code standards

oscard0m commented 6 years ago

To me I'm agree with them. I think we should draft a proposal and dicuss it / tweak it and iterate it!

nerder commented 6 years ago
  1. We should consider the use of https://github.com/typicode/husky
  2. We should consider the use of https://github.com/okonet/lint-staged
  3. I'll think about which hooks we want to use and when
  4. I think we should rename this issue in Adding git hooks and open a general discussion
oscard0m commented 6 years ago
  1. husky

Sounds interesting we can take a look on it. But don't you think we can use a different issue as an improvement of this and move forward?

  1. lint-staged

Same here

  1. & 4.

Yep! Let's use this issue! I'm agree

stefanosaittamrf commented 6 years ago

Nope i think that the proposed PR to fix this is already re-inventing the wheel a little bit, plus since this is a considerable change on the workflow i'll like to discuss it before to have acceptance on what a pre-commit should do. (ie: test + lint fix? only lint and no autofix? only tests?)

oscard0m commented 6 years ago

Ok, let's have the discussion then. Con you MarkDown all the topics to discuss so we can go one by one please? :)