oscardelben / Color-Picker-Pro

Color Detection Tool for Designers and Developers
http://fructivity.com
505 stars 50 forks source link

The keyboard shortcut to copy color is wrong when the keyboard layout differs from qwerty #3

Closed bpierre closed 13 years ago

bpierre commented 13 years ago

Hi,

First, I would like to thank you for this useful tool!

My keyboard layout is Bépo.

When I hit Command + Maj + P, nothing happens.

If I hit Command + Maj + J (J with Bépo = P with Qwerty), the copy works fine.

So I think the key is hardcoded. Could you change it to consider the keyboard layout?

Thanks!

oscardelben commented 13 years ago

Hi bpierre. Yes the j=key is hardcoded, I'll see if I can come up with a more general solution. I'll probably add a preference for choosing the key in the preferences.

oscardelben commented 13 years ago

I've added support for this (along with the ability to change the hotkey in the preferences). Look for an update in the coming days!

bpierre commented 13 years ago

Nice, thanks!