search

oscarfonts / mapbox-gl-cordova-offline

Offline vector maps in Cordova using Mapbox GL JS
Other
60 stars 36 forks source link

Add map language selection #26

Closed jpilet closed 6 years ago

oscarfonts commented 6 years ago

This is a very handy functionality, but specific to OpenMapTiles, and different from this project's scope.

Isn't it possible to use the separate klokantech utility? If not, what are the limitations? Can they be handled apart? (for instance, forking openmaptiles-language)

jpilet commented 6 years ago

Actually this change alone does not work. I had to do the following https://github.com/JpmGuides/mapbox-gl-js/commit/11650a88b7373936b7cad9454c7c6d213c8f1389

So probably this PR should be closed without merging. But the validation in the spec to accept mbtiles sources should probably be part of what mapbox-gl-cordova-offline ships by default.