search

oscarh / vimerl

A set of erlang plugins for VIM. This is not maintained, better use som modern fork of this!
159 stars 99 forks source link

erlangFun not used? #11

Open djui opened 13 years ago

djui commented 13 years ago

Hej,

I can't see where erlangFun for syntax highlighting is used. In fact, all my fun declarations are as normal text. Is this intended?

oscarh commented 13 years ago

I don't think that is intended, but I can't really remember.

What do you propose?

djui commented 13 years ago

Well, if is the regexp was deleted by accident, you might be able to restore from git history. Otherwise writing a regexp should be rather straightforward as I saw it exists already foe the folding functionality.

djui commented 13 years ago

I think I found the commit when erlangFun (erlangFunction?) was removed. Maybe by accident? 885c4114475d6690f648034bd7a5f661e57d993f

djui commented 13 years ago

Ok, I guess I have a pattern now. It looks like this:

syn match erlangFun /^\%([a-z]\w*\|'\w\+'\)/
:
hi link erlangFun Function
oscarh commented 13 years ago

Hmm, since it was on the rewrite branch, maybe I didn't care much about keeping it. Maybe the pattern was to permitting....

djui commented 13 years ago

At least in my usage, having erlangFun is needed, otherwise I don't get any syntax highlighting for fun definitions. If you want, I can create a pull request and you can have a look at it and then merge it. Maybe I am overlooking something here, because it strikes me that nobody else complaints about this obvious missing highlighting. I have to say, I just started to use it... so "noob alert".

oscarh commented 13 years ago

Yes please do that. If you can base your fork on my master it would be good. The integration branch isn't going nowhere fast :(

djui commented 13 years ago

Ok, I hope I can do it tonight. Btw: Are use using something corresponding to Distel for Emacs?

oscarh commented 13 years ago

No not really. What are you using Distel for?

djui commented 13 years ago

Distel can do various things, among others:

In general Distel communicates with a specified erlang node that has a given code tree loaded and uses then beam information for lookups, debug, finding things.

It shouldn't be too hard to write a prototype of Distel for Vim, as a lot of functionality is actually in erlang, rather than emacs (/vim).

Are you using ctags?

oscarh commented 13 years ago

Maybe this chat shouldn't be in the issue about erlang funs not highlighted... I'll send you a message instead :)

geraud commented 13 years ago

Hi Any news on this pull request?

oscarh commented 13 years ago

Hmm, maybe I'm wrong, but I recall this being merged... Maybe it never happened though...