search

oscarhiggott / PyMatching

PyMatching: A Python/C++ library for decoding quantum error correcting codes with minimum-weight perfect matching.
Apache License 2.0
187 stars 32 forks source link

Pass -mno-avx2 compiler flag only to x86_64 architectures #92

Closed mghibaudi closed 8 months ago

mghibaudi commented 8 months ago

CMake does not use the -mno-avx2 flag on non x86_64 architecture, e.g. PowerPC and ARM architectures.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (e183b7a) to head (81c27b1).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #92 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 3 3 Lines 348 348 ========================================= Hits 348 348 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

oscarhiggott commented 8 months ago

Hi @mghibaudi thanks for this, what's the reason for changing -O3 to -O2? I'd have thought it would be preferable to keep -O3 for arm64, for example.

mghibaudi commented 8 months ago

Good point Oscar - tested on ARM and IBM PowerPC g++. -O3 is supported.

oscarhiggott commented 8 months ago

Great, thanks!