search

oscarlai1998 / pe

0 stars 0 forks source link

No consistency in commands for features #10

Open oscarlai1998 opened 3 years ago

oscarlai1998 commented 3 years ago

For Public User, command of features are by strings. Screenshot 2021-04-16 at 5.13.11 PM.png

Where as for an admin user, command for features are by integers Screenshot 2021-04-16 at 5.13.27 PM.png

There should be some consistency in features.

nus-pe-bot commented 3 years ago

Team's Response

This was a conscious choice. For the admin, there are a lot of commands that they can do that are similar in nature (e.g. Admin cannot just type "add" , they have to type "add canteen" or "add store in canteen"), and typing out the command will quickly get confusing and tiresome to type. In contrast, the user had fewer commands, each of a different nature (e.g. "menu", "reviews", "add")

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I disagree with the rejection. Given that the application should be a command line interface application. The ideal scenario is if you can execute all commands in one command. e.g. add store .... or delete menu ... I believe having two ways to execute commands, one using numbers and one using commands is more confusing. Given that an admin can access the public mode also and as an admin he has admin privileges, he would want to check the changes on public mode, thus he has to constantly change modes. Changing modes and having a different way to execute command (one using numbers, one using command strings) would be confusing.