search

oscarlevin / discrete-book

An open textbook for Discrete Mathematics, as taught at the University of Northern Colorado
http://discrete.openmathbooks.org/dmoi3.html
Other
208 stars 64 forks source link

Improve the index #84

Closed oscarlevin closed 3 years ago

oscarlevin commented 5 years ago

Working with @mitchkeller and @mattboelkins, we will improve the index for better and more consistent coverage.

Work to be done on "index" branch. All pull requests should be made into this branch, which will be merged into master and edition when indexing work is complete.

Suggested workflow: Fork and clone discrete-book, checkout index branch. Then

  1. Claim a section by posting on this issue.
  2. Create a new branch "index-sec-x-y": git checkout -b index-sec-x-y
  3. Complete work.
  4. Checkout index branch, pull from upstream, checkout index-sec-x-y, rebase index (to incorporate other's work).
  5. Push index-sec-x-x to your fork (git push -u origin index-sec-x-y); create pull request with base: index.

To build the book to check your work, after setting up makefile.paths, enter make html-fresh (you probably just need to do this one time; it will make diagrams and webwork problems) or make html (after the first time).

mitchkeller commented 5 years ago

I will do section 1.2.

oscarlevin commented 5 years ago

I have indexed section 1.1.

Next I will do chapter 0.

mitchkeller commented 4 years ago

Finally at the point where I've got time calendared each week for this. HTML should build for @mattboelkins. Haven't tested LaTeX.

I have sent #91 for 1.2 and will now do 1.3.

One thing I've just noticed is that for HTML, an idx inside an assemblage just points to the division containing the assemblage. Do we think this is something Rob would fix upstream in PTX?

mitchkeller commented 4 years ago

I have filed #92 for 1.3 and will now move on to 1.4.

oscarlevin commented 4 years ago

Thanks @mitchkeller . Your sections have been pulled in. I've finished 0.2, and will do 0.3 and 0.4 next.

Are you sure about the assemblage index entries? When I compile the html, idx entries in an assemblage get reported as in a "summary" (since I recently renamed assemblage to summary). Do you have an example to point me to?

Either way, we can wait for Rob to fix it (if needed) and anyway I plan to change almost all the assemblages into either theorems or definitions that will get styled like assemblages, as part of the HTML styling work that we are doing right now with David.

mitchkeller commented 4 years ago

Let me pull the latest PTX when I'm on my home computer this evening and see. Perhaps there's an update I'm missing that fixed this, because I was definitely only seeing subsection in the index for things where I had put an idx inside an assemblage.

davidfarmer commented 4 years ago

Not sure if this is an example, but there are PreTeXt environments which are/were not handled properly for idx entries: the reference goes to the parent (sub)section.

We need Rob to fix that bug. We should not change the markup just to get around that bug.

This issue says it is closed, but is it fixed? https://github.com/rbeezer/mathbook/issues/753

On Tue, 12 Nov 2019, Oscar Levin wrote:

Thanks @mitchkeller . Your sections have been pulled in. I've finished 0.2, and will do 0.3 and 0.4 next.

Are you sure about the assemblage index entries? When I compile the html, idx entries in an assemblage get reported as in a "summary" (since I recently renamed assemblage to summary). Do you have an example to point me to?

Either way, we can wait for Rob to fix it (if needed) and anyway I plan to change almost all the assemblages into either theorems or definitions that will get styled like assemblages, as part of the HTML styling work that we are doing right now with David.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, orunsubscribe.[AABTULH4IQYUPV5X3N23QP3QTNAUBA5CNFSM4IYN4DKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOOR PWSZGOED4MY6A.gif]

mitchkeller commented 4 years ago

Assuming the October 2 on which that was fixed is 2019 (I'm having issues telling, since the issue was opened in 2017.), then I suspect that it's just that I haven't pull PTX since Rob added that fix. I'll confirm tonight.

mitchkeller commented 4 years ago

Yup. Outdated PreTeXt was the culprit. I now see "Summary" in the index (with a functional knowl) for the assemblages with idx inside.

mitchkeller commented 4 years ago

Picking up with 1.5.

mitchkeller commented 4 years ago

Working on 1.6 next.

mitchkeller commented 4 years ago

1.7 had no index-worthy content, as mentioned in #96. Thus, Chapter 1 is now done.

oscarlevin commented 4 years ago

Chapters 0 and 1 are done (mod copy editing).

I'll move on to chapter 3 and 4. @mitchkeller, do you want to tackle chapter 2?

I propose we ignore chapter 5 as this is in such a need of a rewrite anyway, I'd rather not have anyone find it through the index.

mitchkeller commented 4 years ago

Ooh! We get to skip chapters for indexing because they need to be rewritten?! I have one or two of those when we get to my book, too.

Yes, I will do Chapter 2.

mattboelkins commented 4 years ago

Gentlemen,

I've proved an unworthy partner here. Apologies for my long absence from the discussion. About two weeks ago I entered end-of-term survival mode.

What can I do to contribute?

Matt

On Wed, Dec 11, 2019 at 10:59 AM Mitchel T. Keller notifications@github.com wrote:

Ooh! We get to skip chapters for indexing because they need to be rewritten?! I have one or two of those when we get to my book, too.

Yes, I will do Chapter 2.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/oscarlevin/discrete-book/issues/84?email_source=notifications&email_token=ADKDQJK6SZMBQU7T7X25ZP3QYEE7FA5CNFSM4IYN4DKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGTUNJA#issuecomment-564610724, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKDQJMHIWJ3VTLQ2B7HP73QYEE7FANCNFSM4IYN4DKA .

oscarlevin commented 4 years ago

No worries. @mattboelkins , do you want to start on chapter 3? I'll move on to chapter 4.

mattboelkins commented 4 years ago

I'll start on chapter 3 next week. Thanks for your patience @Oscar Levin oscarlevin@gmail.com

I hope you're both enjoying a real break.

Matt

On Mon, Dec 23, 2019 at 12:07 PM Oscar Levin notifications@github.com wrote:

No worries. @mattboelkins https://github.com/mattboelkins , do you want to start on chapter 3? I'll move on to chapter 4.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/oscarlevin/discrete-book/issues/84?email_source=notifications&email_token=ADKDQJODBVEKSNWN4MIB2IDQ2DV45A5CNFSM4IYN4DKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHRQ5QQ#issuecomment-568528578, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKDQJNSUKF5K6L4IZ7TNX3Q2DV45ANCNFSM4IYN4DKA .

mitchkeller commented 4 years ago

I have just sent the PR #99 to get the indexing of Chapter 2 done.

oscarlevin commented 4 years ago

I finally got around to approving @mitchkeller 's chapter 2 pull request. I'm going to do Chapter 4 today and would be happy to knock out chapter 3 at the same time, unless you have some partial work on this, @mattboelkins.

mattboelkins commented 4 years ago

I don't have any partial work on it. And I think I'm going to have to pass on this. C19 has made a real mess of my work life at GVSU, and normal time that I have in the summer to work on writing projects looks to have vanished.

Thanks for your understanding, Oscar.

Matt

On Thu, May 21, 2020 at 12:00 PM Oscar Levin notifications@github.com wrote:

I finally got around to approving @mitchkeller https://github.com/mitchkeller 's chapter 2 pull request. I'm going to do Chapter 4 today and would be happy to knock out chapter 3 at the same time, unless you have some partial work on this, @mattboelkins https://github.com/mattboelkins.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/oscarlevin/discrete-book/issues/84#issuecomment-632176637, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKDQJILYHAZ3DVXVLP25NDRSVF2PANCNFSM4IYN4DKA .