oscarmlage / django-cruds-adminlte

django-cruds is simple drop-in django app that creates CRUD for faster prototyping

BSD 3-Clause "New" or "Revised" License

424 stars 81 forks source link

Fixed file upload issue when having file or image fields using … #126

Open A4TIF opened 4 years ago

A4TIF commented 4 years ago

…InlineAjaxCRUD.

jquery.ajax-plugin.js was serializing data, whereas the latest FormData interface allows file uploads. FormData is supported on all latest browsers.

125

telenieko commented 4 years ago

The InlineAjax functionality is currently lacking any testing, that makes it very risky to merge any changes that touch that. So this PR will need to be held back until someone volunteers that part of the test suite (preferably in a separate PR so the current behaviour can properly be tested prior to merging this).

A4TIF commented 4 years ago

I agree testing is definitely required. If I get some free time next week, I will try to cover it, but can't commit on it right now. Thanks.