Fixing multiple anchors on one line

oscarmorrison / md-page

📝 create a webpage with just markdown

https://oscarmorrison.github.io/md-page/

MIT License

1.29k stars 98 forks source link

Fixing multiple anchors on one line #26

Closed szepeviktor closed 6 years ago

szepeviktor commented 6 years ago

...and Beautifying comments. Fixes #25

oscarmorrison commented 6 years ago

Hi @szepeviktor thanks for the PR.

Unfortunately this broke the existing behaviour of the a href:

This: https://github.com/oscarmorrison/md-page/pull/26/files#diff-9a9569e9d73f33740eada95275da7f30L33 is supposed to check if url is local or external url, and then add a target="_blank" if it's external. this PR breaks that

oscarmorrison commented 6 years ago

Merged before I caught the bug, this PR has now been reverted. Can you please change regex, build and resubmit? 11ef84282ff0ef21dab36a1cca36c400183852f9

szepeviktor commented 6 years ago

Is regex: /<a\shref[^"]+">/g, okay?

szepeviktor commented 6 years ago

I am really lost here.

oscarmorrison commented 6 years ago

All goo @szepeviktor this fixed it https://github.com/oscarmorrison/md-page/pull/27