French accent issue - Githubissues

oscarmorrison / md-page

📝 create a webpage with just markdown

https://oscarmorrison.github.io/md-page/

MIT License

1.29k stars 99 forks source link

French accent issue #57

Closed jgwill closed 1 year ago

jgwill commented 2 years ago

Hi So far, very useful. I was wondering if the french accent issue you can see in the image can be fixed with ease :) ? regards

oscarmorrison commented 2 years ago

PRs welcome

benjaminwiseboy commented 2 years ago

Hello, I'm new to Open source. How can I contribute to this topic ?

oscarmorrison commented 2 years ago

https://www.freecodecamp.org/news/how-to-contribute-to-open-source-projects-beginners-guide/

heyallan commented 2 years ago

What is the character that is failing? How to reproduce?

adsuth commented 2 years ago

What is the character that is failing? How to reproduce?

Based on context, probably a C-Cedilla ( ç ).

Having trouble reproducing the problem, seems to process them fine for me. Has this been patched?

StefanoCappellini commented 2 years ago

It's a matter of charset encoding. Their server doesn't specify any charset encoding within the Content-Type header. The browser start searching for the meta tag - that's simply not there, being generated afterwards - reverting to default content type. Possible solutions (I'm not an expert of md-page):

Setting the charset encoding directly from Apache (wise)
Putting the JS and the Markdown inside an html template that pre-defines the charset meta tag (it should work without duplicates, am I correct?)
Saving the file not as UTF-8 but UTF-8 with BOM

StefanoCappellini commented 2 years ago

I've just set up a small demo:

With content-type charset: http://tests.codingwh.com/md-page-accent/
Without: http://tests.codingwh.com/md-page-accent/without
With BOM: http://tests.codingwh.com/md-page-accent/bom/

It happens, obviously, only if the default charset of the browser is different from utf8 :D

oscarmorrison commented 1 year ago

See: https://github.com/oscarmorrison/md-page/blob/main/docs/common_problems.md