search

oscarotero / psr7-middlewares

[DEPRECATED] Collection of PSR-7 middlewares
MIT License
668 stars 56 forks source link

split a simpler json-schema validator from the route-based-validator #46

Closed abacaphiliac closed 7 years ago

abacaphiliac commented 8 years ago

split a simpler json-schema validator from the multi-validator. the simple validator handles a single schema and there is no route-based logic. the file-per-route implementation consumes the simple validator.

abacaphiliac commented 8 years ago

this is preliminary work. i need to update documentation.

abacaphiliac commented 8 years ago

@oscarotero thanks for the review! i've added a new commit to require $next. this enforcement allowed me to remove two branches in the validator middlewares.

i still need to add documentation, and when this is all done i will squash the commits. how does the latest change set look?

abacaphiliac commented 8 years ago

@oscarotero updated docs. i think my change set is stable, unless you have some other feedback.

let me know if the changes to the json-schema test make you nervous. i can split this request. i noticed that there were some false positives, and i had forgotten to update the test's assoc config after we renamed it : /

sander-bol commented 7 years ago

Thanks for the improvements - really appreciate them.

abacaphiliac commented 7 years ago

@sbol-coolblue no problem! i really appreciate the feedback. my builds are failing right now because of some issue with the composer dependency versions. i'll get it working and then we can all discuss. also, i still need to update the error handler. i haven't forgotten.

abacaphiliac commented 7 years ago

@sbol-coolblue @oscarotero i made some changes based on your feedback last week. the build failed because a composer dependency was not able to be installed. see the build output: https://travis-ci.org/abacaphiliac/psr7-middlewares/builds/175723278

i was able to resolve by changing "nikic/fast-route": "0.*" to "nikic/fast-route": "^0.7", so i think something happened recently with nikic/fast-route or with league/route. if you're interested, i will submit the version change in a separate pull.

i'll also update the error handler this week : )

sander-bol commented 7 years ago

Running into the same issue. I'll create a PR for the fast-route change.

oscarotero commented 7 years ago

Oops!! I've merged this by mistake. Can you create a new pull request for the remaining things? (the error handler and that stuff) Sorry :(

abacaphiliac commented 7 years ago

@oscarotero you got click-happy! yes it's not a problem at all. i think the error-handler changes can be done in a compatible fashion. do you mind holding off on the tag until i can complete this work? would take the pressure off of me haha.

oscarotero commented 7 years ago

Don't worry. I have not planned a new release in this week, there are still some things to do. Thanks

abacaphiliac commented 7 years ago

no problem. i'll start working on it tonight. do you have a documented release schedule?

oscarotero commented 7 years ago

No really, but I'd like to close other issues like https://github.com/oscarotero/psr7-middlewares/issues/50 before tagging