allow JSON-validator default error-handler to be overridden.

[abacaphiliac]

based on some feedback here: https://github.com/oscarotero/psr7-middlewares/pull/46

the error handler receives the psr request, response, and an array of validation errors. the default error handler responds with a 422 status code, application/json content-type, and the json-encoded array of errors.

the route-based multi-file wrapper also accepts an error handler override, which is passed through to the underlying validator.

@oscarotero @sbol-coolblue please tell me what you think.

[oscarotero]

Hello. Thanks for you work. I suggest the following:

• Use CallableTrait that provide the arguments() method to pass extra arguments to the handler and executeCallable() private method to execute the callable safely. You can see
• The error handler should have the signature handler($request, $response), used by routers and other error handlers, using the server attributes to pass other objects. For example, errorHandler saves the exception in the request.
• There's no setWhatever methods in other middlewares, so I suggest to rename setErrorHandler to simply errorHandler, to keep the api consistency.

You can see, for example in the errorHandler middleware:

• Save the exception in the request
• Execute the handler
• Provides a way to get the exception from the handler

[abacaphiliac]

@oscarotero thank you. will make updates ASAP.

[abacaphiliac]

@oscarotero implemented suggestions.

are you ok with the public constant KEY for the attribute key? i named it for consistency. is there a value i should use instead of "JSON_ERRORS"?

[oscarotero]

@abacaphiliac JSON_ERRORS is fine but maybe I'd use a more specific key (such JSON_VALIDATION_ERRORS) to say clearly that are validation errors, not parsing errors (or other type of errors). Anyway, I think it's a great work. Thank you.

[abacaphiliac]

@oscarotero thank you for the guidance. i'll update to the more specific key value, add some error handler docs per suggestion by @sbol-coolblue , and squash the commits.

[abacaphiliac]

@oscarotero squashed. please let me know if there is something else i can do.

[oscarotero]

@abacaphiliac Just one thing and I'll merge (I swear): A way to get the errors in the same way than, for example ErrorHandler

So, the error handler could be something like this:

$errors = JsonValidator::getErrors($request);

echo json_encode($errors, JSON_UNESCAPED_SLASHES);

Thanks

[abacaphiliac]

@oscarotero no worries. we're in this together, however long it takes : )

the static helper simplified my unit tests. thanks for the suggestion. i do have another recommendation now. i'll submit another request.

[abacaphiliac]

implemented the suggestion, btw.

[abacaphiliac]

@oscarotero checking in. any outstanding TODOs that i'm missing?

[oscarotero]

Sorry, I did not received the notification. Merged. Thanks for your effort (and patience) 👍

[abacaphiliac]

@oscarotero my pleasure. i hope we get the chance to collaborate again : )