Please review my Twitter client app

[oscarso]

The required Twitter Client app with Fragments is completed. Please review /cc @codepathreview @codepath

GIF Walkthrough: https://github.com/oscarso/CPTWC_Frag/blob/master/CodePath_Android_TwitterClientFrag.gif

Thanks a lot!

Best, Oscar

[codepathreview]

:+1: Project looks good, glad you were able to finish all required stories

• Nicely done architecting the fragments (base class and extension classes) such that you put as much code and logic as possible in the base class and then used abstract methods to define only the specific behavior where they differ!
• Good to see you properly communicated the user to the user timeline fragment from the profile activity.
• Nice to see you used the ViewPager to properly setup the tabs!
• Good use of view holder pattern inside adapter
• Consider adding progress bars to your app whenever a network request goes out
• Try to implement more optional features so that you will get to play with more widgets and understand complexities involved

We have provided a detailed Twitter Redux Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

[oscarso]

Thanks, I will seriously review those hints !!!!

Sent from my iPhone

On Dec 21, 2015, at 12:35 AM, CodePath Reviewers notifications@github.com wrote:

Project looks good, glad you were able to finish all required stories

Nicely done architecting the fragments (base class and extension classes) such that you put as much code and logic as possible in the base class and then used abstract methods to define only the specific behavior where they differ! Good to see you properly communicated the user to the user timeline fragment from the profile activity. Nice to see you used the ViewPager to properly setup the tabs! Good use of view holder pattern inside adapter Consider adding progress bars to your app whenever a network request goes out Try to implement more optional features so that you will get to play with more widgets and understand complexities involved We have provided a detailed Twitter Redux Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

— Reply to this email directly or view it on GitHub.