Open oscarso opened 8 years ago
:+1: Good work getting all required stories done. A few notes after checking out the code:
ListView
.We have provided a detailed Project 1 Feedback Guide here which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of Android development is learning the correct patterns and conventions.
My basic Instagram Client is completed. Please review /cc @codepathreview @codepath
While I could have spent time working on the additional feature, I actually spent time playing with the layout, image view properties...and have a few questions.
Question(s): Q#1: I played with Picasso fit() , centerInside(), and centerCorp() functions. But, I realize that I must still set minHeight = 200dp in the ImageView. I don't feel comfortable with a fix constant value (i.e. 200dp) because I want this to be able to fit all sorts of device screen and resolution. What value should I set ? Suggestions ?
Q#2: Also, for ImageView, there are "wrap_content" and "match_parent", and etc. Is there a preferred settings for all app ? Like, use "wrap_content" for this, and "match_parent" for that, and minHeight=200dp ?? Or, it depends ? I find these settings confusing and never know what is the best settings for any devices: tablets, phone screens, and etc..
Thanks!