search

oscartbeaumont / tauri-specta

Completely typesafe Tauri commands
MIT License
291 stars 27 forks source link

feat!: add a way to specify a plugin name #32

Closed Suyashtnt closed 10 months ago

Suyashtnt commented 10 months ago

This refactors the config option to allow for custom plugin names for people who want to use this tool with a plugin

BREAKING: This completely changes the configuration Struct into a custom one

This also adds a flake.nix with a devshell for NixOS users. Not sure if that should also be in this PR

Suyashtnt commented 10 months ago

I would also prefer if the nix stuff isn't committed to the repo.

Should I rather add that in a seperate PR? Once LGTM you can remove the flake.nix, flake.lock, and .envrc files along with the .direnv/ entry in the gitignore

oscartbeaumont commented 10 months ago

I would rather just remove the Nix-related files before merging this PR! Nix is very cool but I don't use it and from my understanding, it isn't used widely enough for it to be worth adding extra clutter to the root of the repo.

Suyashtnt commented 10 months ago

I would rather just remove the Nix-related files before merging this PR! Nix is very cool but I don't use it and from my understanding, it isn't used widely enough for it to be worth adding extra clutter to the root of the repo.

What I meant is remove the files before the merge but first make sure the rest is alright.

oscartbeaumont commented 10 months ago

Remove the nix files and I am happy to merge this into the v2 branch.

I am going to hold off doing a release until I finish some more work on Specta's next release candidate and release it. You should be able to safely lock to a Git commit for now, but be aware you will want to use specta = "=2.0.0-rc.1" in your project when using the tauri_specta v2 branch.

oscartbeaumont commented 10 months ago

Thanks heaps for your contribution. This has come up before and is very needed feature!