oschulz / ValueShapes.jl

Duality of view between named variables and flat vectors in Julia
Other
12 stars 5 forks source link

ConstValueDist Tests #39

Closed sthayashi closed 3 years ago

sthayashi commented 3 years ago
codecov[bot] commented 3 years ago

Codecov Report

Merging #39 (686fcd2) into master (37878f0) will increase coverage by 1.21%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   92.75%   93.97%   +1.21%     
==========================================
  Files          13       13              
  Lines         649      647       -2     
==========================================
+ Hits          602      608       +6     
+ Misses         47       39       -8     
Impacted Files Coverage Δ
src/value_shape.jl 91.66% <0.00%> (+3.66%) :arrow_up:
src/const_value_dist.jl 97.05% <0.00%> (+17.64%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 37878f0...686fcd2. Read the comment docs.

sthayashi commented 3 years ago

Test for Distributions.quantile not added. Not sure if it will change in the future.

oschulz commented 3 years ago

Is this ready to be merged?

sthayashi commented 3 years ago

Yes