search

oschulz / ValueShapes.jl

Duality of view between named variables and flat vectors in Julia
Other
12 stars 5 forks source link

Adds tests for ConstValueDist constructed using a NamedTuple #44

Closed sthayashi closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #44 (f87a92d) into master (32dba1b) will increase coverage by 0.87%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   92.85%   93.73%   +0.87%     
==========================================
  Files          13       13              
  Lines         686      686              
==========================================
+ Hits          637      643       +6     
+ Misses         49       43       -6
Impacted Files Coverage Δ
src/const_value_dist.jl 97.14% <0.00%> (+17.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 32dba1b...f87a92d. Read the comment docs.

sthayashi commented 3 years ago

A test for https://github.com/oschulz/ValueShapes.jl/blob/32dba1b02f61cf794c3a126461aa4c4f0e01f05a/src/const_value_dist.jl#L46 isn't added, because it sounds like it may be changed in the future. Easy enough to add a simple tests. Otherwise this PR is ready.

oschulz commented 3 years ago

Good to merge?

sthayashi commented 3 years ago

I'll say yes, and fix the ConstValueDist constructor in a different PR.

oschulz commented 3 years ago

Ok, I'll merge then.