search

oschwald / geoip2-golang

Unofficial MaxMind GeoIP2 Reader for Go
ISC License
1.89k stars 195 forks source link

"go get" errors out because of "test-data" submodule #13

Closed omerkirk closed 8 years ago

omerkirk commented 9 years ago

Hi I was using your library previously without issues. However when I tried to update my libraries for a fresh install I got the following error.

git --git-dir=/Users/omerkirk/Projects/go/src/github.com/oschwald/geoip2-golang/.git submodule update --init --recursive No submodule mapping found in .gitmodules for path 'test-data' package github.com/oschwald/geoip2-golang: exit status 1

This is probably simple to fix with manually cloning, still it would be a good idea to fix it here.

oschwald commented 9 years ago

Thanks for the report. I am unable to reproduce this with 1.5 on linux/amd64 using a new $GOPATH. Could you provide me with specific steps to reproduce the issue?

jvehent commented 9 years ago

I'm encountering this as well.

$ go version
go version go1.5.1 linux/amd64
$ go get github.com/oschwald/geoip2-golang
# cd .; git --git-dir=/home/myuser/go/src/github.com/oschwald/geoip2-golang/.git submodule update --init --recursive
No submodule mapping found in .gitmodules for path 'test-data'
package github.com/oschwald/geoip2-golang: exit status 1
oschwald commented 9 years ago

Very strange. I just tested with a new GOPATH on go1.5.1 linux/amd64, and did not experience the issue. What version of Git are you using? What is the content of github.com/oschwald/geoip2-golang/.gitmodules?

oschwald commented 9 years ago

Are you using vendoring? This sounds like this Go issue.

omerkirk commented 9 years ago

You are right I am using the experimental vendoring. I will try to go get without it and let you know.

On Fri, Sep 25, 2015, 01:20 Gregory Oschwald notifications@github.com wrote:

Are you using vendoring? This sounds like this Go issue https://github.com/golang/go/issues/12573.

— Reply to this email directly or view it on GitHub https://github.com/oschwald/geoip2-golang/issues/13#issuecomment-143065049 .

oschwald commented 8 years ago

I am going to close this as it appears the issue is fixed in Go 1.6.