This PR fixes the compilation errors by banging Clone everywhere 💔 .
This will be eventually fixed by the GraphView / NetworkView abstraction, which will be very cheap to clone/copy, but for now this should do.
We should nevertheless open a tech debt ticket to remove all these extra instances of Clone, as it shouldn't be possible (imho) to clone a graph, the users should be using the GraphAPI functions to get GraphView s out of a graph.
Note: This PR is opened against the base branch mb/seed-set, which means we would need to first merge this one, rebase mb/seed-set against master and finally merge everything.
This PR fixes the compilation errors by banging
Clone
everywhere 💔 .This will be eventually fixed by the
GraphView
/NetworkView
abstraction, which will be very cheap to clone/copy, but for now this should do.We should nevertheless open a tech debt ticket to remove all these extra instances of
Clone
, as it shouldn't be possible (imho) to clone a graph, the users should be using theGraphAPI
functions to getGraphView
s out of a graph.Note: This PR is opened against the base branch
mb/seed-set
, which means we would need to first merge this one, rebasemb/seed-set
against master and finally merge everything.