oscoin / osrank-rs

A pre-alpha osrank implementation in Rust.

http://oscoin.io/

3 stars 3 forks source link

Port the code to use the GraphAnnotator #69

Closed adinapoli-mndc closed 5 years ago

adinapoli-mndc commented 5 years ago

This PR ports the code to use the new GraphAnnotator abstraction.

It's marked as draft as it relies on the unreleased new version of graph-api.

codecov-io commented 5 years ago

Codecov Report

Merging #69 into master will decrease coverage by 0.2%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   80.66%   80.45%   -0.21%     
==========================================
  Files          14       14              
  Lines        1081     1090       +9     
==========================================
+ Hits          872      877       +5     
- Misses        209      213       +4

adinapoli-mndc commented 5 years ago

As discussed with @MeBrei, I am now merging this as the discussion about the to_annotation closure doesn't directly affect this, as we used to have a closure in the past anyway (i.e. set_osrank) so this is just trading one lambda for another 😉