oscoin / osrank-rs

A pre-alpha osrank implementation in Rust.
http://oscoin.io/
3 stars 3 forks source link

Nightly benchmarks seems to be broken #82

Closed adinapoli-mndc closed 4 years ago

adinapoli-mndc commented 4 years ago

When running the nightly benchmarks, I do get:

monadic/osrank-rs (adinapoli/issue-46-bump-readme) > RUST_BACKTRACE=1 cargo bench -- nightly                          
    Finished release [optimized] target(s) in 0.08s
     Running target/release/deps/osrank_naive_development-9d8d738db756c006
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/libcore/result.rs:1084:5
stack backtrace:
   0: std::panicking::default_hook::{{closure}}
   1: std::panicking::default_hook
   2: std::panicking::rust_panic_with_hook
   3: std::panicking::continue_panic_fmt
   4: rust_begin_unwind
   5: core::panicking::panic_fmt
   6: core::result::unwrap_failed
   7: osrank::benchmarks::util::construct_network
   8: osrank_naive_development::main
   9: std::rt::lang_start::{{closure}}
  10: std::panicking::try::do_call
  11: __rust_maybe_catch_panic
  12: std::rt::lang_start_internal
  13: main
error: bench failed

They used to work, so something happened here.

adinapoli-mndc commented 4 years ago

Ah, I understand now what's going on: those benchmarks relied on the cargo .csv data files, which we have now moved into a different repo. I will have to think how we can solve this elegantly both for CI and locally.