oscope-dev / scope

Scoping user machines
https://oscope-dev.github.io/scope/
BSD 3-Clause "New" or "Revised" License
6 stars 3 forks source link

checks and setups use the same language in `scope doctor run` #44

Closed technicalpickles closed 8 months ago

technicalpickles commented 9 months ago

Consider:

apiVersion: scope.github.com/v1alpha
kind: ScopeDoctorSetup
metadata:
  name: bundle-update
spec:
  # order: 100 # default value
  cache:
    paths:
      - Gemfile*
      - .ruby-version
  setup:
    exec:
      - bash -c "bundle check && bundle install"
  description: Check for updates to bundled dependencies

Here is the output when this needs to run:

The Gemfile's dependencies are satisfied
sync hooks: ✔️ (fix, pre-commit, pre-push, post-checkout, post-merge)
Bundle complete! 315 Gemfile dependencies, 623 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
3 installed gems you directly depend on are looking for funding.
  Run `bundle fund` for details
 INFO Check `bundle-update` failed. Fix ran successfully.

(Note, the output is from the setup running which is what https://github.com/ethankhall/scope/issues/42 is about)

I'm not sure it is a "check", or that it "failed". It is just something that detected was needed to happen, and it ran successfully.

ethankhall commented 8 months ago

I think this was fixed with my refactor, the verbage has been expended to describe what exaclty happened. Let me know if it doesn't resolved it.

technicalpickles commented 8 months ago

I pulled main, and it's still called a check:

 INFO Check initially failed, fix was successful, group: "bundle-update", name: "1"
 INFO Check was successful, group: "03-bundler", name: "1"
 INFO Check was successful, group: "02-ruby-version", name: "1"
 INFO Check was successful, group: "01-rbenv", name: "1"
 INFO Check was successful, group: "00-homebrew", name: "1"
 INFO Check was successful, group: "00-github-ssh", name: "1"
 INFO Check was successful, group: "00-github-cli", name: "1"
 INFO Check was successful, group: "00-aws-sso", name: "1"