search

oscope-dev / scope

Scoping user machines
https://oscope-dev.github.io/scope/
BSD 3-Clause "New" or "Revised" License
6 stars 3 forks source link

ScopeDoctorSetup report as a check failing initially, but fix is successful #61

Closed technicalpickles closed 8 months ago

technicalpickles commented 8 months ago

With config:

apiVersion: scope.github.com/v1alpha
kind: ScopeDoctorSetup
metadata:
  name: bundle-update
spec:
  # order: 100 # default value
  cache:
    paths:
      - Gemfile*
      - .ruby-version
  setup:
    exec:
      - bash -c "bundle check >/dev/null || bundle install"
  description: Check for updates to bundled dependencies

I get:

 INFO Check initially failed, fix was successful, group: "bundle-update", name: "1"

This feels a little weird, because it's not a check, and it's saying it failed (what failed?), and that a fix (what fix?) was successful. Possibly related to https://github.com/ethankhall/scope/issues/60

Or maybe worth considering for https://github.com/ethankhall/scope/issues/49

ethankhall commented 8 months ago

Can you switch to https://ethankhall.github.io/scope/docs/models/ScopeDoctorGroup ? I've deprecated Setup and Check and unified it under Group, which makes the verbiage more consistent.

technicalpickles commented 8 months ago

Confirmed switching to the group makes it more consistent 👍🏻