LKM: Merge one blackhole into another. - Githubissues

oscourse-tsinghua / rcore_plus

Rust version of THU uCore OS. Linux compatible.

MIT License

172 stars 26 forks source link

LKM: Merge one blackhole into another. #48

Closed gjz010 closed 5 years ago

gjz010 commented 5 years ago

Merged fs and sfs into main project. Only tested on x86, may even fail to compile on other platforms. Filesystem refactored.

I will try to merge on my own first.

jiegec commented 5 years ago

some files should not be checked into the tree.

jiegec commented 5 years ago

So many comments are not removed.

jiegec commented 5 years ago

Documents and code formatting are required.

jiegec commented 5 years ago

What's the usage of a new vmalloc? The global allocator is implemented for this purpose.

jiegec commented 5 years ago

If possible, please rebase upon dev branch.

jiegec commented 5 years ago

Please spilt one big commit into small ones.

wangrunji0408 commented 5 years ago

I think we can separate these changes into multiple PRs:

LKM infrastructure: minimal code which can load and run hello.ko
File system refactors:

I prefer to make VirtualFS an individual FS implementation. Like:
```
impl FileSystem for VirtualFS {...}
impl INode for INodeContainer {...}
```
And put it to rcore-fs-rootfs in rcore-fs crate :)
File system extern "C" interface for LKM:

I prefer to separate it to a crate like rcore-fs-ucore.
IPI on x86_64

I'm happy to help (merge the code) if you need. @gjz010

gjz010 commented 5 years ago

I will do this.

在这个分支上整理、合并你这学期的工作，要求每个commit的内容逻辑上相对完整（如增加syscall、加入新的实现代码、修正已有的bug等），在commit log中进行相应的说明并以Signed-off-by的形式在commit log最后留下你的姓名和邮箱（可以用git config设置user.name和user.email后在commit时加-s选项）。为了简化开发过程而进行的非通用修改（如hard code编译的TOOLCHAIN_PREFIX等）不应出现在任何一个commit中