Edit Existing Exchanges

[amykirschner]

Makes Transactions that have already occurred, editable (pencil icon in sidebar like people?)

[amykirschner]

I spelled someone's name wrong in the memo field. Super awkward. No way to correct or amend it.

[amykirschner]

Relates to closed issue #113. I can edit dates on new exchanges but I still can't edit the dates on already posted transactions.

[amykirschner]

Also like #113, can only be changed in the current year to preserve tax reporting integrity.
-Can't change amounts or parties for previous years. -Could edit memo field at any time (see name spelling error above). That has no direct relation to tax reporting.

[amykirschner]

@ziyan-junaideen if you could work on this next it would be helpful. I have a user who needs to separate 2016 transactions between 2 accounts (currently all in one account). Would be a huge mess for me to delete. Hoping editing solves problem.

[amykirschner]

To summarize, need to be able to edit:

• [ ] both parties in transactions
• [x] memo.note field
• [ ] date
• [ ] amount we'll skip for now b/c may be complicated
• [x] pencil icon like other tabs would be great
• [ ] BUT must only be editable for current calendar year. Previous years off limits

[ziyan-junaideen]

About editing existing exchanges... it is normally the way not to allow any changes... for example in banks... if there is a typo, its eternal... if the numbers are wrong then we would reverse the entries and make new ones... This is not any separate feature, but a new record opposite direction to make nullify the transaction.

now to come back to the matter at hand...

You are asking to make some fields editable. There are certain concerns that I will list below. I am not saying it is impossible to do, but rather it might not be shallow as just 'edit an entry' and might have more depth.

Fields not mentioned here might be alright to let change.

Both parties in transaction

I am not sure how healthy this would be. If things are calculated on the fly, we may be safe. But if there is some kind of memory, we may have inconsistencies. For example...

• Users A: 100 credit, B: 100 credit
• User A gives b 10 credit
• It is registered as B has 110 credit
• We change the exchange as B gave A
• But since there is some memory, the balances would be B = 110; A = 90, which is wrong

Amount

Can again be a problem, as mentioned above.

[ziyan-junaideen]

@amykirschner ^^^

[amykirschner]

@ziyan-junaideen yes, understand your concerns. We're technically accounts receivable and accounts payable, more accounting software than banking. Our legal boundary is around making sure income is reported to irs correctly in a certain year. Which explains why I want editing but NOT for previous years. Only in current year. Mistakes do get made in recording transactions and editing them is preferable to reversing at this point (since I'm the only one manually controlling records). At scale, issue is different and may be reversed then.

[amykirschner]

I still want to be able to edit the memo field as per the original issue. That should not affect anything.

I still have the use case mentioned two weeks ago as well. Will fill in more: Client is a non-profit with 2 legal entities. Previous director put all transactions in one account/tax entity. New director, after consulting with tax advisor, wants to have two accounts and properly record income and expenses to their correct tax identity. It matters to them because one legal entity is non-profit and one is not. All previous years will not be corrected, left as is.

But for 2016, they want to move some of the sales and some of the purchases to a new account so their books are accurate by year end. I was hoping there might be an easy way to automate this instead of me doing hours of manual data entry.

I see what you are saying and am leaning towards abandoning this issue (except for memo edit - that would save me so many problems!). Any other solution you see to the one>two accounts that I am missing or do I just need to do it manually?

[ziyan-junaideen]

I am only now starting to look in to the feature... I will start by allowing you to edit the memo. That is easy. The rest I guess will have to come after Jan 1 as you said we might halt after Nov 30th and this got delayed because I was unusually busy last week.

[ziyan-junaideen]

@amykirschner : As I see... we will need to add a 'reverse' feature to reverse transactions if...

1. The amount changes
2. The user (s) changes

This is because, when a transaction happens, part of it goes from sender to recipient. When a 'transaction' in the physical world happens, in the data there might be many transactions, 2 at minimum among 3 parties, unless there is no commission.

When we change...

• we create reverse transactions for commission
• we reverse the payment done for the worker
• we charge reenact the charge (payment + commission) for the new user or the new amount

Does this make sense? or have i not understood it proper?

[ziyan-junaideen]

Pushed to staging

[ziyan-junaideen]

Currently, in staging you have ability to change any thing. There is no restriction. When some fields are changed, I believe it needs to trigger a chain reaction to propagate changes let it be in the form of

• updating other fields (ex: updating date will need to udpate dates in other exchanges which were related)
• reversing and creating new exchanges (ex: with people and amount changes)

[amykirschner]

@ziyan-junaideen thanks - I see this. Getting to it as soon as possible.