search

oscurrencyVRL / oscurrency

Affero licensed Mutual Credit/Time Bank software, operational in statewide b2b system
Other
15 stars 2 forks source link

Customer input credit card, not showing in stripe #190

Closed amykirschner closed 7 years ago

amykirschner commented 8 years ago

Hi @ziyan-junaideen

I switched 'update card' on for a customer with an overdue bill. Previous card on file in stripe not valid (number change for fraud warning).

She indicated by email on Nov 10 that she logged in and entered number. I can confirm login.

When I go to stripe, I see no record of an updated card or data transfer. Where do you think it went?

(In production, you can see login as "M.L" on Nov 10 at 14:26)

amykirschner commented 8 years ago

I also sent you read access to stripe at jdeen address

ziyan-junaideen commented 8 years ago

@amykirschner : I confirm that I have access to your dashboard

ziyan-junaideen commented 8 years ago

We actually didn't do a functional change in the payment but rather handled some redirects if marked invalid.

I have memory of a feature that will e-mail you when the user updates the card. I will have to check to confirm.

amykirschner commented 8 years ago

Thanks. I did not get an email of a card update from her. She sent me an email herself.

ziyan-junaideen commented 8 years ago

My mistake. There is no separate e-mail feature. I was wondering if she had actually encountered an error and the email not getting delivered. So that is not the case.

amykirschner commented 8 years ago

She did not report any error message nor did I get one.

ziyan-junaideen commented 8 years ago

You also tried it? I think I will step in straight to debugging.

amykirschner commented 8 years ago

Sorry, no I didn't try to recreate it. I just didn't get an auto-email from the system with an error report.

ziyan-junaideen commented 8 years ago

Never mind, I can use a test card and a test account and check.

amykirschner commented 8 years ago

@ziyan-junaideen let me know if you need anything else from me.

ziyan-junaideen commented 8 years ago

@amykirschner : sorry, was out of service due to bad weather followed by bad health. I am expecting to start today.

ziyan-junaideen commented 8 years ago

When updating a profile using the credit card form, the code actually doesn't reach the stripe update credit card logic.

ziyan-junaideen commented 8 years ago

I got the feature to ping Stripe, this should be fixed. There were some bugs in the old code. How ever I can see some improvements in to how to use Stripe.

Currently, we are creating a new stripe customer when updating the card. Thus do note that the old customer id might not be working further.

Will push to staging and production now.

ziyan-junaideen commented 8 years ago

@amykirschner : have you been able to check the updates. It was deployed.

amykirschner commented 8 years ago

@ziyan-junaideen will note about new customer. I can manually delete old records in stripe.

Can you tell me what happened to the data entered by customer in this issue? It didn't ping stripe but it's not supposed to be saved in our system.....so it went nowhere? I'll ask her to enter again as a test of the fix. Just making sure the data isn't hanging out somewhere it isn't supposed to be. Thanks!

ziyan-junaideen commented 7 years ago

@amykirschner : The data wasn't been received in Stripe and not stored locally as well. I checked the code. While the information is relayed through the server, it is not saved in the db.

amykirschner commented 7 years ago

@ziyan-junaideen thanks - just double checking.