oscurrencyVRL / oscurrency

Affero licensed Mutual Credit/Time Bank software, operational in statewide b2b system
Other
15 stars 2 forks source link

ReDo Offers Tab #199

Closed amykirschner closed 7 years ago

amykirschner commented 7 years ago

Issues - It's hard to scan offers, still too much text, pictures small.

1st line of text is not visible

maybe 3 across?

responsive table

ziyan-junaideen commented 7 years ago

@amykirschner : photos are resized to be 240x240px. If we are going to have some thing like 3 columns, we will need images to be at least about 400px wide. Shall i set the limits to some thing like 512x512px.

ziyan-junaideen commented 7 years ago

@amykirschner some thing like this?

screenshot from 2017-02-11 23-22-56

ziyan-junaideen commented 7 years ago

The stretched look and feel of the image is because they are 240x240. Currently it is stretched to 370px. For ultra dense screens it is good to have twice the size (4 times the area).

ziyan-junaideen commented 7 years ago

I just noticed the checkbox above... after some updates...

marketplace

ziyan-junaideen commented 7 years ago

And some thing like this in a phone. screenshot from 2017-02-14 06-50-03

amykirschner commented 7 years ago

That's looking good! Cap title text at 2 lines?

I'm concerned about creating a problem where poorly sized photos get too blurry.
Maybe make full screen 5 photos across? Then we know max photo size of 240x240

ziyan-junaideen commented 7 years ago

One thing we can do is to increase the photo size, but that will only solve the matter for the future.

In the other hand as you said, we can increase the number of columns... we got a 12 grid... we are now at 4 units (4 * 3 = 12).

We can go 4 columns with 3 units width or go 6 columns wide with each column been 2 units.

ziyan-junaideen commented 7 years ago

@amykirschner I think going 6 will be too much, will push an update to 4.

Caping by number of lines, i have an idea, i am not sure if it will work. other wise i will cap it by number of characters so that it will be roughly 2 lines in desktop mode

amykirschner commented 7 years ago

yes - update to 4 sounds good.

If you think it's not buggy :) go ahead and push to production when done and I'll review there.

ziyan-junaideen commented 7 years ago

@amykirschner : I pushed an update not seen the comments about image... and i undid it...

I am making changes to the app so that photos uploaded will store a larger version. No current version is sufficient for our requirements as the largest available is 72px. Just enough for that small box. I am going to add a new polaroid version with a higher resolution.

Unfortunately this will only effect new uploads. Because older images are already resized. So we will see such stretching in any old photo.

ziyan-junaideen commented 7 years ago

If we make the photos small, there won't be much text. Here is how it looks with latest updates. Older photos / orders will be less crisp. The new ones will be fine.

One approach we can take is to push updates to production that will increase image size for new offers. Then after there are like 3 or 6 new offers we can make the new layout to show. Just an idea.

vbsr marketplace

ziyan-junaideen commented 7 years ago

Updates available in staging.

amykirschner commented 7 years ago

@ziyan-junaideen this is looking so good!

amykirschner commented 7 years ago

Notes:

amykirschner commented 7 years ago

When those changes get made, go ahead and push to production and we'll clean up any inconsistencies there. When you push to production can you apply same format to request tab? THANK YOU!

ziyan-junaideen commented 7 years ago

Understood

ziyan-junaideen commented 7 years ago

download

amykirschner commented 7 years ago

@ziyan-junaideen thank you!

I think the main photos on the offer tab are still too large. Not many people have high res logos that size. Can you make it default to the same size as on the click through page. That looks good! Maybe 75%

amykirschner commented 7 years ago

I'm so happy with this new layout!

amykirschner commented 7 years ago

oops one more - when I decrease to a mobile size view, photos stay same size, I assumed they would shrink to match screen size. ?

ziyan-junaideen commented 7 years ago

@amykirschner You mean when in mobile to be full screen... ya sure i will push and update.

ziyan-junaideen commented 7 years ago

offer-image-widht-mobile

ziyan-junaideen commented 7 years ago

For smaller screens it will be full width (not very clear above because the background is also white) and for tablets and above it will be half screen.

ziyan-junaideen commented 7 years ago

@amykirschner ^^

amykirschner commented 7 years ago

@ziyan-junaideen sorry for the delay. I think we're good here! I need to redo some of the photos but I think it's just a manual fix no code needed. Closing.

THANK YOU!