Make Offer Tab visible Externally

[amykirschner]

Now that we have the new layout via #199, I'd like to make it possible for people to view the tab and offers BEFORE logging in. This is our biggest customer request.

• [x] https://mighty-sea-9942.herokuapp.com/groups/1#offers needs a new address. Not sure how to get something like a subdomain such as offers.vbsrmarket.com

• [x] Make the entire tab visible if people navigate to it

• [x] Make individual offers visible before log in. If people want to send a question or hit BUY NOW, then they would be directed to log in page.

[ziyan-junaideen]

It is not necessarily required to have a sub-domain (like offers.example.com) to have some thing public facing. But I think it will be nice to have.

This will require a DNS config in your domains control panel. We will also have to add it to Heroku config, which I can do. If you are interested and if you tell me the host you use I can search and give you some instructions.

The other option is to make it just another page. For example exmple.com/public/offers. For this we will not need any DNS config.

[amykirschner]

@ziyan-junaideen, it seems like the easier option would be to not need dns config and just make it another page. example.com/offers is good enough for me, I just can't market that crazy heroku address.

[amykirschner]

Let me know what you need from me to move forward

[ziyan-junaideen]

@amykirschner : ack Amy. I will implement it as a page. It is the easiest. Otherwise we will need to have it as a sub domain which will involve DNS changes.

[ziyan-junaideen]

By permission, it seems as though the offers should be possible to be read by a guest. I am going to quickly scout the code to see if I can get the same page showing for a guest.

[ziyan-junaideen]

We have some thing like this in staging: https://stormy-cove-staging.herokuapp.com/public_offers

[amykirschner]

@ziyan-junaideen good! When I click an offer on that link - it requires sign in. I'd like to make more visible before login. Maybe require login if they attempt to click Pay Now or send a message. Maybe make the first half of the offer visible and require login to see the whole thing? What do you think?

[ziyan-junaideen]

Ya need to change that. 2nd and 3rd check boxes.

[ziyan-junaideen]

@amykirschner : do we need to show expired offers? Also I am using /public_offers/1 kind of a link if you didn't notice. offer/:id is taken and making it publicly visible is complicated. If you would like to use a more user friendly name than public_offers I can change it.

[ziyan-junaideen]

I am showing the whole offer, not a subset. I think for search engines, having all the details is a good thing. Then the pay now link will redirect the user to the login page if the user hasn't already.

Its in staging. You can have a look.

[amykirschner]

@ziyan-junaideen great!

• [ ] don't show expired offers. thanks

• [ ] instead of Public_offers can we just do offers?

hmm.. good about pay now to login. I'm undecided on showing the whole offer. Since the message system is spotty, I direct people to put their contact info in offer. They may not want it all showing. I'm inclined to push it and then take feedback from members.

I'd saw let's handle above two issues and then push to production. If there are tweaks as time goes on then I'll make a new issue Thank you!

[ziyan-junaideen]

Offers is already taken by the original offers section. How ever if I can use a different name if you give.

[amykirschner]

oops! you already said that.

openoffers with no underscore?

On Jun 12, 2017, at 2:53 PM, Ziyan Junaideen notifications@github.com wrote:

Offers is already taken by the original offers section. How ever if I can use a different name if you give.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[ziyan-junaideen]

Sure...

[ziyan-junaideen]

@amykirschner I pushed and update. Now it shows only active offers.

• At least one offering
• Expiry date is in the future

https://stormy-cove-staging.herokuapp.com/openoffers

[ziyan-junaideen]

@amykirschner : btw do you think we need to add a link or some details in to the home page where users who have not logged in will probably land.

[amykirschner]

@ziyan-junaideen good catch! I call that the "skillbank" page and frankly I ignore it and have planned to remove it.

When I hit Pay Now in staging it took me to an error screen just now instead of the skillbank page.

What I'd really like to do is send people to a login page of my choice when they click pay now. Can I do that?

[amykirschner]

Can I have it redirected to here: http://vbsrmarket.com/accounttypes/

[ziyan-junaideen]

Login page of your choice, could you please elaborate?

[ziyan-junaideen]

Checking the error

[ziyan-junaideen]

The button will now link to the login page.

[amykirschner]

Good - push to production! Just posted an issue and tagged you on photo size. Thank you!

[ziyan-junaideen]

Pushing to production

[amykirschner]

Woo Hoo! :)