search

osdnk / react-native-reanimated-bottom-sheet

Highly configurable bottom sheet component made with react-native-reanimated and react-native-gesture-handler
MIT License
3.33k stars 328 forks source link

Not working properly when used with RNCamera, also with BarcodeScanner from expo on Android #66

Open roshangm1 opened 5 years ago

roshangm1 commented 5 years ago

Hi, I was trying to have QRCode scanner in the bottomsheet. I tried using RNCamera (using react-native-qrcode-scanner), also tried BarcodeScanner from expo. But I am having some issues on android.

Here's what happens when used with camera (randomly):

  1. I have to click button (which shows bottomsheet) multiple times to show the bottomsheet.
  2. Sometimes, I can't show the bottomsheet at all.
  3. This is only happening on android.

I have tried to reproduce the issue. Here is the link to the github repo for the example:

https://github.com/nirajniroula/bottomsheet-test

@osdnk @brentvatne

turanibrahim commented 4 years ago

You have to give height on RNCamera component otherwise its doesn't show up. Flex:1 doesn't work and height: '100%' givin full screen height. I used hardcoced height for both bottomsheet and rncamera component otherwise camera doesn't fit as expected.