oseawey / timthumb

Automatically exported from code.google.com/p/timthumb
0 stars 0 forks source link

couldn't handle image from https connection #151

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Picasa update their link share with https connections 
2. picasa update their domain name for sharing link using 
googleusercontent.com, so i add it up in the script

What is the expected output? What do you see instead?
the expected image is thumbnail(doh), but what i see instead an error that the 
image is not found

What version of the product are you using? On what operating system?
the newest version. i'm using win7 64, firefox 3.xx

Please provide any additional information below.
Fixed the problem by adding googleusercontent.com to the script and changing 
the https connection to the usual http (at first i just add new domain name, 
but the error "couldn't find the image" still appear. stop after i change the 
connection)

Original issue reported on code.google.com by hnaz...@gmail.com on 3 Feb 2011 at 4:16

GoogleCodeExporter commented 9 years ago
Try to replace line 559 from 
    if (stristr ($src, 'http://') !== false) {

to

    if ((stristr ($src, 'http://') !== false) || (stristr ($src, 'https://')) !== false) {

This one seems like fix your problem.

Original comment by djevrek on 3 Feb 2011 at 8:27

GoogleCodeExporter commented 9 years ago
Thanks :) i'll update if there's a future error

Original comment by hnaz...@gmail.com on 4 Feb 2011 at 3:24

GoogleCodeExporter commented 9 years ago
miss a closing statement, fixed to 
if ((stristr ($src, 'http://') !== false) || (stristr ($src, 'https://') !== 
false) ) {

but the code works :D

Thanks 

Dian

Original comment by hnaz...@gmail.com on 4 Feb 2011 at 3:46

GoogleCodeExporter commented 9 years ago
This has now been commited, thanks for the report! :)

Original comment by BinaryMoon on 6 Feb 2011 at 10:55

GoogleCodeExporter commented 9 years ago

Original comment by BinaryMoon on 6 Feb 2011 at 10:56

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Still Not getting images from https connections.....there is no line 559 in the 
latest version that says "if (stristr ($src, 'http://' !== false) {"

Original comment by tune2sud...@gmail.com on 5 Dec 2012 at 7:43

GoogleCodeExporter commented 9 years ago
how did you fix it. I have the smae problem

Original comment by talentai...@gmail.com on 14 Feb 2013 at 4:58