Open emulvi opened 1 year ago
What is version of ttpy
packages?
I downloaded the github version in February of this year, so I believe that is version 1.2.1. I did docker pull daskol/ttpy
yesterday and ran docker inline as
$ docker run -it --rm -v "$PWD":/workspace daskol/ttpy
Python 3.10.6 (main, Aug 3 2022, 10:13:24) [GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>>
I also ran it on google colab to see how it would be behave; it installed version 1.2.1:
and it gave the same output as my laptop, with the rank conserved:
Looking at the ksl.py file in the tar file at https://pypi.org/project/ttpy/#files, it is different from the one here on github. Notably, there's a y0 = y0.round(1e-14)
at line 65 on github that isn't in the pypi verions; that could be causing the change in rank.
Yes. Package ttpy
in PyPI is outdated and doesn't have some fixes so you can install ttpy
directly from GitHub
git clone --recursive https://github.com/oseledets/ttpy.git
pip install ttpy
or use docker image.
The problem is that the version of ksl on github and docker is not working properly because it is changing the rank within the propagation. I think the problem is the line 65 with y0 = y0.round(1e-14)
, which was also noted in issue #79.
I have deleted the line in #96. We need investigate commit 0e7bf47b. It looks like a garbage hotfix for nothing.
Thank you!
After adding a random tt of rank 5+ as noise to a tt with rank 1 to reach a rank of 6+, when ksl propagates it on docker, the rank is 1 instead of maintaining the rank of the tt inputed to ksl.
For example, with the code:
The output with docker is:
Whereas the output with ttpy from github is: