osenco / mpesats

M-Pesa TypeScript Wrapper for integrating the Daraja API
https://developer.safaricom.co.ke/Documentation
GNU General Public License v3.0
22 stars 6 forks source link

Add Framework specific presets and Tests #2

Closed ayimdomnic closed 1 year ago

ayimdomnic commented 3 years ago

Aim

Hey, Great work on the library.

I am thinking of adding framework specific presets for this so users of nestjs, adonis, loopback 4 can just inject this to their entry points and let the framework do all the work

if this is a direction you want this to go I'll be more than happy to make the PR this long weekend

Also, it would be cool to have an issue and PR templates for folks like me who can't type for sh*t

Regards

maukoese commented 3 years ago

Hi, sure thing.

I think supporting that out of the box would be amazing.

Sent from my iPhone

On Oct 30, 2021, at 09:29, Odhiambo Dormnic @.***> wrote:

 Aim

Hey, Great work on the library.

I am thinking of adding framework specific presets for this so users of nestjs, adonis, loopback 4 can just inject this to their entry points and let the framework do all the work

if this is a direction you want this to go I'll be more than happy to make the PR this long weekend

Also, it would be cool to have an issue and PR templates for folks like me who can't type for sh*t

Regards

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

ayimdomnic commented 3 years ago

@maukoese Then I propose this structure, we make this a lerna monorepo and separate the framework specific presets as packages as well, that way we can achieve backward compatibility and also not force users of the core package to install the other distributions of this

packages/
   @osenco/
       mpesa-core/
       mpesa-nestjs/
       mpesa-lb/
       mpesa-adonis/

what do you think?