Closed hedonistrh closed 2 years ago
Hello! Thanks for opening ScraperFC's first ever issue on GitHub! So since Burnley conceded a penalty this weekend, I'm no longer able to replicate this issue. I'll try and put a fix together to hopefully avoid this issue in the future. Thank you!
I just pushed a fix for this issue. If nobody runs into problems in the next couple of weeks, I'll close it.
Thanks a lot. Also that was nice coincidence. ⚽ So I am not closing it as you mentioned something about that. 👍
Closed due to no more reported incidences.
Hey, thanks for that great repo. 🙇 That is really helpful. I was doing some experimentation with Understat scraper and encountered with Exception when I tried with following
However, if we replace last line with the following
It is working without any issue.
I found the reason of the problem but not sure about the exact issue. 👨💻 First, let's see full-error message.
I checked team-links which is used in this scraping, they looks correct.
Then, realized that one of them is always failing and failed one is related with "Burnley" as we saw that failure when our link in team_links become following
Then, when we check given link from understat, we can see that there is no Penalty under Situation part at all. So that is coming from not so consistent representation in the website. On the other hand, maybe handling with that situation can be added. Currently I do not have enough time to do that but sharing details in case.
Thanks. 💯