Understat dataframe.append deprecated

oseymour / ScraperFC

Python package for scraping soccer data from a variety of sources

GNU General Public License v3.0

222 stars 49 forks source link

Understat dataframe.append deprecated #40

Closed rubeenvm2 closed 5 days ago

rubeenvm2 commented 5 months ago

From Understat.py: 634 game_states = game_states.append( 635 pd.DataFrame(row_array.reshape(1,-1)),#, columns=game_states.columns), 636 ignore_index=True 637 ) Being game_states a df, I think append is deprecated in pandas, should be changed to concat().

oseymour commented 3 months ago

Hey @rubeenvm2! Thanks for raising this. I haven't fixed these in the past because the deprecation hadn't become effective. I don't have any time for ScraperFC right now, I'm working on other projects/life things. I'll update the append() calls to concat() when I get back to ScraperFC though!

oseymour commented 3 months ago

Following up on this: this would be a good community contribution, if somebody wanted to go through and fix these

oseymour commented 5 days ago

Updated in v3.0.0.