search

oseymour / ScraperFC

Python package for scraping soccer data from a variety of sources
GNU General Public License v3.0
239 stars 52 forks source link

Corner Case for Fotmob's Shot Scraping Sorting #5

Closed hedonistrh closed 2 years ago

hedonistrh commented 2 years ago

Hey Owen, I am still working on Fotmob scraper as well. While doing that, also checked your code. And realized that, in the current implementation, you are getting minute of the shot here and doing bit post-processing. So it can deal with addition time. (if i understand correctly 45+3 become 48 there) Then sorting shots by minutes here.

However, that can cause not-fully correct ordering if i am not missing anything. Because with that sorting, a shot happening at the 46' will happen before than 45+2' one. That is actually corner case but just would like to mention that. 😅

I know that is still in development (and maybe you already modified that) but in case you missed that part. 🗒️

oseymour commented 2 years ago

Yeah I haven't finished that code up yet. I was planning on removing that, just added it for troubleshooting during dev. Thanks!