osgi / osgi.enroute.site

GitHub Pages repo for OSGi enRoute website
https://enroute.osgi.org/
Apache License 2.0
18 stars 54 forks source link

Typos in "Persistance With JPA" tutorial #198

Closed katcaola closed 5 years ago

katcaola commented 5 years ago

First Typo

In the "The JPA Composite Application" section of the "Persistance With JPA" tutorial, the code snippet for entering the impl-artifactId is

Define value for property 'impl-artifactId': rest-service

but the output reads

impl-artifactId: dao-impl-jpa

Later in the tutorial the rest-service is mentioned again in the rest-app-jpa.bndrun

-runrequires: \
    osgi.identity;filter:='(osgi.identity=org.osgi.enroute.examples.microservice.rest-service)',\

so this means the output should be changed to

impl-artifactId: rest-service

Second Typo

The last command in the tutorial is to run the jar that was just created by the mvn package command:

java -jar rest-app-jpa/target/rest-app.jar

But the jar you just created is not rest-app.jar but rest-app-jpa.jar. The command should be changed to

java -jar rest-app-jpa/target/rest-app-jpa.jar

I will add these to the PR I am currently working on.

katcaola commented 5 years ago

Fixed with Commit #199