Major problems with test structure.

[timothyjward]

Pull Request #16 was reverted in the recent commit 884923b658e0252ae40b12fb1790c75eb7762f04 Which means that the tests no longer use a sensible JUnit structure.

Also there are several other issues with the test structure:

• The use of a boolean to encapsulate pass/fail semantics is completely against the JUnit model (see https://github.com/osgi/osgi.security-tests/blob/master/org.osgi.security.sysatt110.test/src/org/osgi/security/sysatt110/test/Activator.java#L22) This boolean is just used to do test logging. This should be implemented correctly using a Verifier rule (see http://junit.org/junit4/javadoc/latest/org/junit/rules/Verifier.html)
• The code is no longer present, but previously Security manager checks were being made as part of individual tests. This should be processed in a common superclass using an @After fixture to avoid polluting tests with other logic.

The current state of the tests fd51af6fb5b40bae69e963a4d1cc62aa4d3eca8a is a huge regression from the previous state.

[Romain-SHT]

The revert of Pull Request #16 was a mistake, sorry for the inconvenience. I integrated your remarks in the sysatt110 bundle, that are the Verifier rule and the migration of SecurityManager's operations in util bundle.