[jpa][tck] missing requirements on test prerequisites

osgi / osgi

OSGi Specification Project Build Repository. Specification, API, implementation, and TCK source code.

https://docs.osgi.org/

Apache License 2.0

104 stars 40 forks source link

[jpa][tck] missing requirements on test prerequisites #733

Open laeubi opened 4 months ago

laeubi commented 4 months ago

For example

org.osgi.test.cases.jpa.junit.JPAService_1_1_TestCase.testUseStandardDataSourceConfig()

seem to require the h2 jdbc bundle because it uses an url of jdbc:h2:mem: but the test bundle has no requirement on this, therefore the TCK happily starts (and fails) in such a case.

https://github.com/osgi/osgi/blob/3bf23c2548cc13c144b7254d1dee7655262b25cf/org.osgi.test.cases.jpa/src/org/osgi/test/cases/jpa/junit/JPAService_1_1_TestCase.java#L67

laeubi commented 2 months ago

this could use

@Referenced(org.h2.Driver.class)