oshaughn / research-projects-RIT

Clean version of research-projects, just with ILE
MIT License
14 stars 14 forks source link

Updates to lalsimutils and CIP #66

Closed chadhenshaw closed 2 years ago

chadhenshaw commented 2 years ago

I've put in various updates to lalsimutils and CIP to facilitate use of chi_pavg as a fitting parameter. I also added in the tripwire-fraction option to CIP that we discussed. I split the commits so you can look at each individually.

Note: there's something weird going on with git's treatment of CIP. I can't seem to get git to render the actual changes I've made, it treats every line as being changed. I suspect this is due to mixed line endings, but it's not clear to me how to resolve this.

oshaughn commented 2 years ago

Oh, we can't merge a commit where you changed the ^M/etc line endings .. that makes for an impossibly huge diff. You will probably have to go back and reimplement the changes by hand again without editing these.

(We went through this once before with CIP, and it was a nightmare diff... it makes review impossible.)