oshazard / apacman

ArchLinux User Repository (AUR) helper and pacman wrapper
https://aur.archlinux.org/packages/apacman/
GNU General Public License v3.0
70 stars 11 forks source link

Improve curlyq output (e.g. for -Syu) #65

Closed creshal closed 8 years ago

creshal commented 8 years ago

curlyq's messages are currently confusing to useless during full upgrades (-Syu), e.g.:

:: Synchronizing aur database...
notice: curl exited with code 51            13  34 [---------------------c o  o  o  o  o  o  o  o  o  o  o  o  o] 38%
notice: curl exited with code 51            14  34 [-----------------------c  o  o  o  o  o  o  o  o  o  o  o  o] 41%
manpage: The peer's SSL certificate or SSH MD5 fingerprint was not OK.
manpage: The peer's SSL certificate or SSH MD5 fingerprint was not OK.-------co  o  o  o  o  o  o  o  o  o  o  o] 44%
notice: curl exited with code 51            22  34 [-------------------------------------co  o  o  o  o  o  o  o] 64%
manpage: The peer's SSL certificate or SSH MD5 fingerprint was not OK.
notice: curl exited with code 51            34  34 [-------------------------------------------------------------]100%
manpage: The peer's SSL certificate or SSH MD5 fingerprint was not OK.

:: Starting full aur upgrade...

What the error message means is that the packages in question don't exist on AUR (any more), but right now you don't even know which packages. With these changes, the output becomes

:: Synchronizing aur database...
notice: curl exited with code 51 on connman-notify [--------------C  o  o  o  o  o  o  o  o  o  o  o  o  o  o  o] 26%
manpage: The peer's SSL certificate or SSH MD5 fingerprint was not OK.
notice: curl exited with code 51 on pandoc-bin  34 [---------------------------------c o  o  o  o  o  o  o  o  o] 58%
manpage: The peer's SSL certificate or SSH MD5 fingerprint was not OK.-----------------c  o  o  o  o  o  o  o  o] 61%
notice: curl exited with code 51 on yswrapdmenu 34 [-------------------------------------------------------------]100%
manpage: The peer's SSL certificate or SSH MD5 fingerprint was not OK.
notice: curl exited with code 51 on dmenu-xft
manpage: The peer's SSL certificate or SSH MD5 fingerprint was not OK.

:: Starting full aur upgrade...

, which is somewhat more useful. Still doesn't solve the underlying problem (trying to download https:/plain/PKGBUILD?h=aur instead of just bailing out), but I've no idea where to fix that one.

oshazard commented 8 years ago

Agreed, helpful for debugging but still not a fix for the bug