search

osheroff / ui_tweaks

Mod that adds a couple of nice UI features to invisible, inc
1 stars 6 forks source link

Forking Permission #3

Open qoala opened 3 years ago

qoala commented 3 years ago

Hi would you be okay with this mod being forked and uploaded as a new entry on the Steam Workshop? (I saw your response on the pull request last year)

I've been able to replace Need A Dollar with modifications to the "steal" UI action, allowing it to also be used if it would reveal negative information (alarm 3+ guard or scientist is carrying nothing; a non-expertly searched guard has no more items, but is approached by an anarchy 5 agent) with a "no loot" popup instead of the inventory panel if so~. Also some completely new improvements (so far, implementing: player pathfinding prefers unnoticed/unwatched tiles given the same distance).

If so, the new mod would include most of your assets and code, with attribution in the Workshop page and github repo. If not, I can release my changes as a separate mod and leave it to users to disable Need a Dollar.

osheroff commented 3 years ago

just open up a pull request with your new features and I'll merge them. at least that's the open source way to do it. if you want to release your own mod i don't care, but the best way to get your features in front of users is to contribute them back to the parent mod

qoala commented 3 years ago

Wasn't sure if you were interested in keeping the Steam Workshop mod updated. As far as I know, Steam Workshop doesn't have any concept of a maintainer role or transferable ownership. If you're not interested in doing so, then perhaps I'm asking for permission to reupload your work as a new entry on Steam once my changes are merged here.

I'd be happy to contribute them as a PR here. Still need to clean them up from the prototyping stage.

osheroff commented 3 years ago

i can poke around and see if I can give you release permissions. or you can just send me a bundle to upload when you're ready, that's fine too. the only thing I can't remember is how to actually package up the mod for release

qoala commented 3 years ago

Sounds good.

I'd ended up writing my own Makefile (https://github.com/qoala/InvisibleInc-BattleRoyale/blob/master/Makefile) for some of my own mods that generates a gitignored out/ folder suitable for the mod uploader. I wasn't familiar with how to teach autoconf or similar tools about completely new dependencies (where the kwad builder is just distributed as a zip file and I haven't added it to my $PATH), so I opted for a separate makeconfig.mk file that can be filled in from the example template.

If you want, bringing that over could be the first PR.

osheroff commented 3 years ago

fine by me!

On Wed, Sep 8, 2021 at 10:35 AM qoala @.***> wrote:

Sounds good.

I'd ended up writing my own Makefile ( https://github.com/qoala/InvisibleInc-BattleRoyale/blob/master/Makefile) for some of my own mods that generates a gitignored out/ folder suitable for the mod uploader. I wasn't familiar with how to teach autoconf or similar tools about completely new dependencies (where the kwad builder is just distributed as a zip file and I haven't added it to my $PATH), so I opted for a separate makeconfig.mk file that can be filled in from the example template.

If you want, bringing that over could be the first PR.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/osheroff/ui_tweaks/issues/3#issuecomment-915435407, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB7P5ELGBURIOGDOR7UDN3UA6NFVANCNFSM5DVH6KVQ .

qoala commented 2 years ago

Given the delays, combined with the Steam Workshop failing to provide such a basic feature as "grant other users permission to update a mod" (so it was always either "you update the mod whenever I make changes" or "I upload a new mod"), I've re-uploaded the mod at https://steamcommunity.com/sharedfiles/filedetails/?id=2660875942