search

oshp / oshp-validator

Venom tests suite to validate an HTTP security response headers configuration against OSHP recommendation.
https://owasp.org/www-project-secure-headers/
GNU General Public License v3.0
100 stars 20 forks source link

[BUG] Fix quoting of variables in test suite #3

Closed JensSkipr closed 1 year ago

JensSkipr commented 1 year ago

Describe the bug

Currently the test suite is not a valid YAML file, due to missing quoting of variables.

To Reproduce Steps to reproduce the behavior:

  1. Go to e.g. https://www.yamllint.com/
  2. Paste test_suite.yml
  3. Click Go button

Expected behavior

In case the file is valid YAML, we can script updates on it to adapt to specific needs while still receiving upstream updates. Also, formatting in IDE seems not to work on an invalid file.

Screenshots image

Desktop (please complete the following information): N/A

Smartphone (please complete the following information): N/A

Additional context N/A

righettod commented 1 year ago

Hi,

Thank you very much for the PR and the fix 😃

I merged the PR.

righettod commented 1 year ago

@JensSkipr Based on your feedback, I added the linter check in the CI pipeline with yamllint . Thank again your precious feedback and PR 💯