search

osiam / connector4java

Native Java API to connect to the REST based OSIAM services
MIT License
8 stars 17 forks source link

Extend SCIM address by display name to be SCIM conform #203

Closed dacrome closed 8 years ago

dacrome commented 8 years ago

Any SCIM multi-valued attribute must have a display name: https://tools.ietf.org/html/rfc7643#section-2.4

Also include display name of multi-valued attributes in unit tests.

dacrome commented 8 years ago

Sorry, currently it is not clear if the SCIM Address should have a display sub-attribute. But I asked the SCIM mailing list.

I'm curious that the Address constructor has a display parameter.

All other SCIM mulit-valued attributes have the display sub-attribute, but currently they are mutable but the SCIM spec says that display has to be immutable. So I think we need to fix this.

tkrille commented 8 years ago

This will be done after OSIAM 3.0

tkrille commented 8 years ago

Ignore my last comment.

tkrille commented 8 years ago

@dacrome:

I'm curious that the Address constructor has a display parameter.

That's because we use inheritance incorrectly. I think we should refactor this with 2.0.

All other SCIM mulit-valued attributes have the display sub-attribute, but currently they are mutable but the SCIM spec says that display has to be immutable. So I think we need to fix this.

It turns out, that the spec defines it inconsistently as immutable, readOnly and readWrite. Particularly, it doesn't even define the attribute for addresses. Nevertheless, we've decided to add this attribute to addresses and also to give the service consumer full control over this field, making it have a mutability of readWrite.